fs: accept Buffer paths in fs.promises.cp#62950
Open
maruthang wants to merge 1 commit intonodejs:mainfrom
Open
fs: accept Buffer paths in fs.promises.cp#62950maruthang wants to merge 1 commit intonodejs:mainfrom
maruthang wants to merge 1 commit intonodejs:mainfrom
Conversation
fs.promises.cp threw ERR_INVALID_ARG_TYPE when given Buffer paths, while fs.cpSync accepted them. The async helper at lib/internal/fs/cp/cp.js calls path.resolve/dirname/join on the raw input, and the path module rejects non-strings. The sync path lives in C++ and accepts Buffer transparently via BufferValue. Convert Buffer/Uint8Array paths to UTF-8 strings at the entry of cpFn so the async implementation matches the documented string | Buffer | URL contract and the sync behavior. URL paths are already pre-converted by getValidatedPath upstream and so are unaffected. Fixes: nodejs#58869 Signed-off-by: Maruthan G <[email protected]>
nodejs-github-bot
added
fs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs.promises.cp threw ERR_INVALID_ARG_TYPE when given Buffer paths,
while fs.cpSync accepted them. The async helper at
lib/internal/fs/cp/cp.js calls path.resolve/dirname/join on the
raw input, and the path module rejects non-strings. The sync path
lives in C++ and accepts Buffer transparently via BufferValue.
Convert Buffer/Uint8Array paths to UTF-8 strings at the entry of
cpFn so the async implementation matches the documented
string | Buffer | URL contract and the sync behavior. URL paths
are already pre-converted by getValidatedPath upstream and so are
unaffected.
Fixes: #58869
Note: I was unable to run the project's test suite locally on this Windows host (no built
out/Release/node). The changed files lint clean and passnode --check. Relying on CI for full verification — happy to iterate on any failures.